update to latest ansible guidelines

apcupsd/tasks/main.yml

@@ -23,7 +23,9 @@
     - usv
 
 - name: gather apcupsd killpower files
-  local_action: stat path=apcupsd/killpower/{{ ansible_hostname }}
+  stat:
+    path: "apcupsd/killpower/{{ ansible_hostname }}"
+  delegate_to: localhost
   register: killpower
   tags:
     - usv
@@ -40,7 +42,9 @@
     - usv
 
 - name: gather apcupsd onbattery files
-  local_action: stat path=apcupsd/onbattery/{{ ansible_hostname }}
+  stat:
+    path: "apcupsd/onbattery/{{ ansible_hostname }}"
+  delegate_to: localhost
   register: onbattery
   tags:
     - usv

branding/tasks/main.yml

@@ -10,7 +10,7 @@
     mode: '0644'
   when:
     - branding_motd is defined
-    - branding_motd != ""
+    - branding_motd|bool
   tags:
     - branding
     - shell
@@ -24,7 +24,7 @@
     mode: '0644'
   when:
     - branding_issuenet is defined
-    - branding_issuenet != ""
+    - branding_issuenet|bool
   tags:
     - branding
     - shell
@@ -67,7 +67,9 @@
     - tls
 
 - name: install gpg to install the apt_key
-  apt: name=gnupg state=present
+  apt:
+    name: gnupg
+    state: present
   tags:
     - branding
     - repos

cups-client/tasks/main.yml

@@ -6,7 +6,7 @@
     name:
       - cups-client
       - cups-bsd
-    state: latest
+    state: present
   tags:
     - cups-client
 

custom-sudoers/handlers/main.yml

+---
+
+- name: check sudoers
+  command: visudo -q -c -f /etc/sudoers

custom-sudoers/tasks/main.yml

 ---
-# file: roles/custom-sudoers/tasks/main.yml
 
 - name: ensure deployment of customized sudoers
   template:
@@ -8,10 +7,7 @@
     owner: root
     group: root
     mode: '0440'
-  tags:
-    - sudo
-
-- name: check whole sudo config
-  command: visudo -q -c -f /etc/sudoers
+  notify:
+    - check sudoers
   tags:
     - sudo

debian-updates/tasks/main.yml

@@ -31,22 +31,15 @@
     - debian-updates
 
 # https://github.com/ansible/ansible/issues/27699
-- name: ensure git module is able to clone
-  command: mount -o remount,exec /tmp
-  tags:
-    - debian-updates
-
+# https://github.com/ansible/ansible/issues/30064#issuecomment-487149251
 - name: ensure git is at the current revision
   git:
     repo: git@git.fsmpi.rwth-aachen.de:larsb/debian-updates.git
     dest: /opt/debian-updates
     key_file: /root/.ssh/debian_updates
     version: HEAD
-  tags:
-    - debian-updates
-
-- name: ensure git module is not able to clone anymore
-  command: mount -o remount,noexec /tmp
+  environment:
+    TMPDIR: /root/.ansible/tmp
   tags:
     - debian-updates