wordpress: fix linter issues; move password lookups to vars

wordpress/defaults/main.yml

@@ -14,3 +14,7 @@ wordpress_dbislocal: true
 wordpress_dbname: "{{ wordpress_name }}"
 wordpress_dbuser: "{{ wordpress_name }}"
 wordpress_dbpassword: ''
+
+# mysql root login password
+# yamllint disable-line rule:line-length
+wordpress_db_password: "{{ lookup('passwordstore', 'db/{{ wordpress_dbhost }}-{{ wordpress_dbtype }} create=true length=20')}}"

wordpress/handlers/main.yml

@@ -2,7 +2,8 @@
 # file: wordpress/handlers/main.yml
 
 - name: reload systemd service files
-  command: systemctl daemon-reload
+  systemd:
+    daemon_reload: true
 
 - name: "restart uwsgi for {{ wordpress_name }}"
   service:
@@ -10,4 +11,4 @@
     state: restarted
 
 - name: create tmpfiles
-  shell: systemd-tmpfiles --create
+  command: systemd-tmpfiles --create

wordpress/tasks/mysql.yml

@@ -24,8 +24,7 @@
     name: "{{ wordpress_dbname }}"
     state: present
     login_user: root
-    # yamllint disable-line rule:line-length
-    login_password: "{{ lookup('passwordstore', 'db/{{ wordpress_dbhost }}-{{ wordpress_dbtype }} create=true length=20')}}"
+    login_password: "{{ wordpress_db_password }}"
   no_log: true
   tags:
     - wordpress
@@ -37,8 +36,7 @@
     password: "{{ wordpress_dbpassword }}"
     state: present
     login_user: root
-    # yamllint disable-line rule:line-length
-    login_password: "{{ lookup('passwordstore', 'db/{{ wordpress_dbhost }}-{{ wordpress_dbtype }} create=true length=20')}}"
+    login_password: "{{ wordpress_db_password }}"
     priv: "{{ wordpress_dbname }}.*:ALL"
   no_log: true
   tags: