lint yaml files

.yamllint

+---
+
+extends: default
+
+rules:
+  comments-indentation:
+    level: warning
+  document-start:
+    level: error
+  empty-lines:
+    max: 1
+  empty-values:
+    forbid-in-flow-mappings: true
+    forbid-in-block-mappings: true
+  line-length:
+    level: warning
+  octal-values:
+    forbid-implicit-octal: true
+    level: warning

tsm-archive/meta/main.yml

 ---
+
 dependencies:
   - role: tsm/tsm-client

tsm-archive/tasks/main.yml

@@ -2,8 +2,8 @@
 # file: tsm-archive/tasks/main.yml
 
 - name: ensure deployment of our config
-  template: src=dsm.sys.j2 dest=/opt/tivoli/tsm/client/ba/bin/dsm.sys
+  template:
+    src: dsm.sys.j2
+    dest: /opt/tivoli/tsm/client/ba/bin/dsm.sys
   tags:
     - tsm
-    - config
-

tsm-backup/defaults/main.yml

 ---
+
 tsm_backup_domains: ['/']
 tsm_backup_virtual: []
 tsm_backup_includes: []

tsm-backup/meta/main.yml

 ---
+
 dependencies:
   - role: tsm/tsm-client

tsm-backup/tasks/main.yml

@@ -2,28 +2,31 @@
 # file: tsm-backup/tasks/main.yml
 
 - name: ensure systemd service file is available
-  copy: src=dsmc.service dest=/etc/systemd/system/dsmc.service
+  copy:
+    src: dsmc.service
+    dest: /etc/systemd/system/dsmc.service
   notify:
     - reload systemd service files
   tags:
     - tsm
-    - config
-    - service
 
 - meta: flush_handlers
 
 - name: ensure deployment of our config
-  template: src=dsm.sys.j2 dest=/opt/tivoli/tsm/client/ba/bin/dsm.sys
+  template:
+    src: dsm.sys.j2
+    dest: /opt/tivoli/tsm/client/ba/bin/dsm.sys
   notify:
     - restart tsm service
   tags:
     - tsm
-    - config
 
 - name: ensure tsm service is enabled and running
-  service: name=dsmc enabled=yes state=started
+  service:
+    name: dsmc
+    enabled: true
+    state: started
   tags:
     - tsm
-    - service
 
 - meta: flush_handlers

tsm-client/handlers/main.yml

@@ -3,4 +3,3 @@
 
 - name: update apt cache
   apt: update_cache=yes
-

tsm-client/tasks/main.yml

@@ -2,26 +2,28 @@
 # file: tsm-client/tasks/main.yml
 
 - name: ensure apt https transport is available
-  apt: name=apt-transport-https state=present
+  apt:
+    name: apt-transport-https
+    state: present
   when: tsm_repo|truncate(5, True, '') == "https"
   tags:
     - tsm
-    - repos
-    - packages
 
 - name: ensure repo key is in keyring
-  apt_key: data="{{ lookup('file', tsm_repo_pubkey) }}" state=present
+  apt_key:
+    data: "{{ lookup('file', tsm_repo_pubkey) }}"
+    state: present
   tags:
     - tsm
-    - repos
 
 - name: ensure repo is activated
-  apt_repository: repo="deb [arch=amd64] {{ tsm_repo }}" state=present
+  apt_repository:
+    repo: "deb [arch=amd64] {{ tsm_repo }}"
+    state: present
   notify:
     - update apt cache
   tags:
     - tsm
-    - repos
 
 - meta: flush_handlers
 
@@ -35,30 +37,41 @@
     state: present
   tags:
     - tsm
-    - packages
 
 - name: ensure there is a log directory
-  file: state=directory path=/var/log/dsm owner=root group=root mode=0750
+  file:
+    state: directory
+    path: /var/log/dsm
+    owner: root
+    group: root
+    mode: '0750'
   tags:
     - tsm
-    - config
 
 - name: ensure special dsmc script is in place
-  copy: src=dsmc dest=/usr/local/bin/dsmc mode=0755 owner=root group=root
+  copy:
+    src: dsmc
+    dest: /usr/local/bin/dsmc
+    mode: '0755'
+    owner: root
+    group: root
   tags:
     - tsm
-    - config
 
 - name: ensure special dsmcert script is in place
-  copy: src=dsmcert dest=/usr/local/bin/dsmcert mode=0755 owner=root group=root
+  copy:
+    src: dsmcert
+    dest: /usr/local/bin/dsmcert
+    mode: '0755'
+    owner: root
+    group: root
   tags:
     - tsm
-    - config
 
 - name: ensure tls anchor certificate is configured
+  # yamllint disable-line rule:line-length
   command: dsmcert -add -server "T-TeleSec GlobalRoot Class 2" -file /etc/ssl/certs/T-TeleSec_GlobalRoot_Class_2.pem
   args:
     creates: /opt/tivoli/tsm/client/ba/bin/dsmcert.kdb
   tags:
     - tsm
-    - config