Merge branch 'clean-variable-leak' into 'master'

Properly scope shared variable spaces

See merge request !8

ad-server-replication/defaults/main.yml

@@ -3,3 +3,5 @@
 ad_admin_password: samba-admin
 smb_model_prefork: false
 smb_prefork_children: 4  # since it is default in 4.10
+smb_domain: "{{ domain.split('.')[0].upper() }}"
+REALM: "{{ domain.upper() }}"

ad-server/defaults/main.yml

@@ -3,3 +3,5 @@
 ad_admin_password: samba-admin
 smb_model_prefork: false
 smb_prefork_children: 4  # since it is default in 4.10
+smb_domain: "{{ domain.split('.')[0].upper() }}"
+REALM: "{{ domain.upper() }}"

nfs-server/defaults/main.yml

+---
+
+nfs_krb: false
+nfs_krb_primary_ad_server: "{{ ad_primary|default(hostvars[groups['servers_ad'][0]]['ansible_host']) }}"

nfs-server/tasks/main.yml

@@ -93,7 +93,7 @@
     - name: create service principal
       # yamllint disable-line rule:line-length
       command: samba-tool spn add "nfs/{{ ansible_fqdn }}" "{{ ansible_hostname | upper }}$"
-      delegate_to: "{{ hostvars[groups['servers_ad'][0]]['ansible_host'] }}"
+      delegate_to: "{{ nfs_krb_primary_ad_server }}"
       tags:
         - nfs-server
         - service-principal
@@ -103,7 +103,7 @@
       command: samba-tool domain exportkeytab "/root/{{ ansible_fqdn }}.keytab" --principal "nfs/{{ ansible_fqdn }}"
       args:
         creates: "/root/{{ ansible_fqdn }}.keytab"
-      delegate_to: "{{ hostvars[groups['servers_ad'][0]]['ansible_host'] }}"
+      delegate_to: "{{ nfs_krb_primary_ad_server }}"
       tags:
         - nfs-server
         - service-principal
@@ -112,7 +112,7 @@
       synchronize:
         src: "/root/{{ ansible_fqdn }}.keytab"
         dest: "/root/{{ ansible_fqdn }}.keytab"
-      delegate_to: "{{ hostvars[groups['servers_ad'][0]]['ansible_host'] }}"
+      delegate_to: "{{ nfs_krb_primary_ad_server }}"
       tags:
         - nfs-server
         - service-principal
@@ -144,7 +144,7 @@
       file:
         path: "/root/{{ ansible_fqdn }}.keytab"
         state: absent
-      delegate_to: "{{ hostvars[groups['servers_ad'][0]]['ansible_host'] }}"
+      delegate_to: "{{ nfs_krb_primary_ad_server }}"
       tags:
         - nfs-server
         - service-principal