lint yaml files

.yamllint

+---
+
+extends: default
+
+rules:
+  comments-indentation:
+    level: warning
+  document-start:
+    level: error
+  empty-lines:
+    max: 1
+  empty-values:
+    forbid-in-flow-mappings: true
+    forbid-in-block-mappings: true
+  line-length:
+    level: warning
+  octal-values:
+    forbid-implicit-octal: true
+    level: warning

dovecot/defaults/main.yml

@@ -6,8 +6,8 @@ dovecot_mail_location: "maildir:~/mail:LAYOUT=fs"
 dovecot_maildir_separator: /
 dovecot_deny_users: []
 dovecot_users_group: users
-dovecot_auth_virtual: no
-dovecot_auth_system: yes
+dovecot_auth_virtual: false
+dovecot_auth_system: true
 dovecot_min_uid: 500
 dovecot_max_uid: 0
 
@@ -18,13 +18,14 @@ dovecot_tls_ciphers: "{{ tls_ciphers }}"
 dovecot_tls_dh_length: 4096
 dovecot_tls_protocols: 'TLSv1.1 TLSv1.2 !SSLv3'
 
-dovecot_dsync: no
-dovecot_dsync_tls: no
+dovecot_dsync: false
+dovecot_dsync_tls: false
 dovecot_dsync_group: dovecot
 dovecot_dsync_address: '0.0.0.0'
+# yamllint disable-line rule:line-length
 dovecot_dsync_password: "{{ lookup('passwordstore', dovecot_dsync_passwordstore ~ ' create=true length=20') }}"
 dovecot_dsync_passwordstore: dsync
 dovecot_dsync_host_attribute: ansible_host
 
-dovecot_content_filter: no
+dovecot_content_filter: false
 dovecot_spam_folder: Spam

dovecot/tasks/main.yml

@@ -9,7 +9,7 @@
       - dovecot-managesieved
       - dovecot-sieve
     state: present
-  tags: 
+  tags:
     - dovecot
     - mail
 
@@ -42,7 +42,7 @@
     state: directory
     owner: dovecot
     group: "{{ dovecot_users_group }}"
-    mode: 0755
+    mode: '0755'
   tags:
     - dovecot
     - mail
@@ -51,7 +51,7 @@
   template:
     src: "sieve/{{ item }}.j2"
     dest: "/var/lib/dovecot/sieve.d/{{ item }}"
-    mode: 0550
+    mode: '0550'
     owner: dovecot
     group: "{{ dovecot_users_group }}"
   with_items:
@@ -70,7 +70,7 @@
   copy:
     src: "{{ item }}"
     dest: "/var/lib/dovecot/sieve.d/{{ item }}"
-    mode: 0750
+    mode: '0750'
     owner: dovecot
     group: "{{ dovecot_users_group }}"
   with_items:
@@ -97,8 +97,7 @@
   service:
     name: dovecot
     state: started
-    enabled: yes
+    enabled: true
   tags:
     - dovecot
     - mail
-

postfix/defaults/main.yml

@@ -9,8 +9,8 @@ postfix_tls_key: /etc/ssl/private/privkey.pem
 postfix_tls_ciphers: "{{ tls_ciphers }}"
 postfix_tls_protocols: '!SSLv2 !SSLv3'
 
-postfix_prefer_lmtp: no
-postfix_enable_memcached: no
+postfix_prefer_lmtp: false
+postfix_enable_memcached: false
 postfix_login_suffix: ''
 postfix_dnsbl_sites:
   - name: zen.spamhaus.org
@@ -21,6 +21,6 @@ postfix_dnsbl_sites:
   - name: list.dnswl.org
     modifier: -5
 postfix_network_access:
-  - cidr: 134.130.5.32/27 # rwth
+  - cidr: 134.130.5.32/27  # rwth
     action: permit
-postfix_content_filter: no # or: spamassassin
+postfix_content_filter: false  # or: spamassassin

postfix/handlers/main.yml

@@ -11,4 +11,3 @@
 
 - name: postmap virtual
   command: postmap cdb:/etc/postfix/virtual
-

postfix/tasks/main.yml

@@ -7,7 +7,7 @@
       - postfix-pcre
       - postfix-cdb
     state: present
-  tags: 
+  tags:
     - postfix
     - mail
 
@@ -29,7 +29,7 @@
     - master.cf
     - main.cf
     - postscreen_access.cidr
-  notify: 
+  notify:
     - restart postfix
   tags:
     - postfix
@@ -56,7 +56,7 @@
   tags:
     - postfix
     - mail
-    
+
 - name: ensure system alias database is present
   template:
     src: aliases.j2

prosody/defaults/main.yml

 ---
 
+# yamllint disable rule:line-length rule:colons
 prosody_modules:
-  - name:        "posix" 
+  - name:        "posix"
     description: "POSIX functionality, sends server to background, enables syslog, etc."
   - name:        "blocking"
     description: "For XEP-0191 Simple Communications Blocking."
   - name:        "csi"
     description: "For XEP-0352 Client State Indication"
-  - name:        "throttle_presence" 
+  - name:        "throttle_presence"
     description: "Supress presence updates if CSI is enabled"
   - name:        "filter_chatstates"
     description: "Supress chatstate updates (someone is typing...) if CSI is enabled"
@@ -23,6 +24,7 @@ prosody_modules:
     description: "Private XML storage (for room bookmarks, etc.)"
   - name:        "vcard"
     description: "Allow users to set vCards"
+# yamllint enable rule:line-length rule:colons
 
 prosody_config_files:
   - prosody
@@ -30,5 +32,3 @@ prosody_config_files:
 
 prosody_user: prosody
 prosody_db: prosody
-
-

prosody/tasks/main.yml

@@ -49,7 +49,7 @@
   service:
     name: prosody
     state: started
-    enabled: yes
+    enabled: true
   tags:
     - prosody
 

prosody/tasks/postgres.yml

@@ -4,17 +4,17 @@
   postgresql_user:
     name: "{{ db_user }}"
     state: present
-  become: yes
+  become: true
   become_user: postgres
   tags:
     - postgres
-    
+
 - name: ensure we have a postgres database
   postgresql_db:
     name: "{{ db_name }}"
     owner: "{{ db_user }}"
     state: present
-  become: yes
+  become: true
   become_user: postgres
   tags:
     - postgres
@@ -26,7 +26,7 @@
     privs: ALL
     state: present
     type: database
-  become: yes
+  become: true
   become_user: postgres
   tags:
     - postgres

spamassassin/defaults/main.yml

 ---
 
-spamassassin_rewrite_subject: no
+spamassassin_rewrite_subject: false
 spamassassin_required_score: '3.0'

spamassassin/tasks/main.yml

@@ -16,7 +16,7 @@
     dest: /etc/spamassassin/local.cf
     owner: root
     group: root
-    mode: 0644
+    mode: '0644'
   tags:
     - mail
     - spamassassin
@@ -27,7 +27,7 @@
     dest: /etc/default/spamassassin
     owner: root
     group: root
-    mode: 0644
+    mode: '0644'
   tags:
     - mail
     - spamassassin
@@ -36,7 +36,7 @@
   service:
     name: spamassassin
     state: started
-    enabled: yes
+    enabled: true
   tags:
     - mail
     - spamassassin