website merge requestshttps://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests2024-02-06T14:20:32+01:00https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/48WEBM support2024-02-06T14:20:32+01:00Dominic MeiserWEBM supportThis PR adds support for .webm files in the sorterThis PR adds support for .webm files in the sorterhttps://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/47Draft: Support for S32022-07-27T18:58:38+02:00Roman KarwacikDraft: Support for S3This commit adds support for using S3 as storage.
TODO:
- [ ] Use auth() directly in files(filename), and not over proxy in nginx
- [ ] Rewrite sorter.py
- [ ] Expose rgw
- [ ] Move data into S3
- [ ] Add interface for admins to upload...This commit adds support for using S3 as storage.
TODO:
- [ ] Use auth() directly in files(filename), and not over proxy in nginx
- [ ] Rewrite sorter.py
- [ ] Expose rgw
- [ ] Move data into S3
- [ ] Add interface for admins to upload new videos
- [ ] What policies do we use for the presigned links (ExpiresIn is currently just 3600, would be bad if the links becomes bad while watching the video)https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/46Impress2021-12-08T18:32:18+01:00Nils BeyerImpressFür die Webseite macht es Sinn, dass wir uns ein kleines Impressum geben.
Als Vorschlag habe ich mich mal an dem [Impressum der FS-Webseite](https://www.fsmpi.rwth-aachen.de/pages/kontakt/impressum.html) orientiert.
![image](/uploads/94...Für die Webseite macht es Sinn, dass wir uns ein kleines Impressum geben.
Als Vorschlag habe ich mich mal an dem [Impressum der FS-Webseite](https://www.fsmpi.rwth-aachen.de/pages/kontakt/impressum.html) orientiert.
![image](/uploads/941e9bb2e878a075a5e75dbf4778b2c9/image.png)https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/45Fix: password escaping in permissioneditor2021-10-13T22:56:56+02:00Nils BeyerFix: password escaping in permissioneditorRelated issues: #390
Nur ein parsing/escaping Fehler im Frontend scheinbar. Der Fix hier zeigt bei mir lokal wieder Sonderzeichen korrekt im Browser an:
![image](/uploads/fc02708ee0b5b5d7e90008535ebd4126/image.png)Related issues: #390
Nur ein parsing/escaping Fehler im Frontend scheinbar. Der Fix hier zeigt bei mir lokal wieder Sonderzeichen korrekt im Browser an:
![image](/uploads/fc02708ee0b5b5d7e90008535ebd4126/image.png)https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/44Docker setup for development2021-10-13T09:57:43+02:00Nils BeyerDocker setup for developmentNichts wirklich spannendes, hilft mir aber beim testen/entwickeln, daher vielleicht interessant:
Ein kleines Docker-Setup, um die Webseite lokal mit `nginx` zu testen. In der `nginx.conf.example` musste ich dafür kleine Anpassungen vorn...Nichts wirklich spannendes, hilft mir aber beim testen/entwickeln, daher vielleicht interessant:
Ein kleines Docker-Setup, um die Webseite lokal mit `nginx` zu testen. In der `nginx.conf.example` musste ich dafür kleine Anpassungen vornehmen, dort waren u.a. auch alte URLs zu finden.https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/43L2P removal2021-10-04T15:38:51+02:00Nils BeyerL2P removalSince L2P is [no longer available](https://maintenance.itc.rwth-aachen.de/ticket/status/messages/37-l2p), authentication currently fails if a user wants to authenticate via L2P. This also includes courses where users can be authenticated...Since L2P is [no longer available](https://maintenance.itc.rwth-aachen.de/ticket/status/messages/37-l2p), authentication currently fails if a user wants to authenticate via L2P. This also includes courses where users can be authenticated by either moodle or l2p, for example [15ss-ex4](https://rwth.video/15ss-ex4/4540).
(!) This merge request is build upon !42 (approved, not merged). **Merge !42 before**.https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/42Feature: Authorize helper2021-10-04T22:42:59+02:00Nils BeyerFeature: Authorize helperRelated issues: #387
Currently, authorization for video playback is mostly based on Basic Auth and alert banners in the video player. This leads to problems like in [MaLo](https://rwth.video/17ss-malo/7794) where users have to cancel t...Related issues: #387
Currently, authorization for video playback is mostly based on Basic Auth and alert banners in the video player. This leads to problems like in [MaLo](https://rwth.video/17ss-malo/7794) where users have to cancel the basic auth in order to access RWTH-SSO login. Furthermore, no helper text can be specified.
This merge request implements an authorization helper which allows users to select their authorization method before video playback. Furthermore, it stores login/password details no longer in the HTTP-Authorization header, but in an session entry. This allows users to switch between videos with different passwords without having to re-authenticate.
![image](/uploads/d686080573af19c26f12adc98408773c/image.png)
Points worth discussing:
- Is it okay to store login/password in the session? Others suggested to store specifically which videos/lectures were authorized. This is more complex, and login/passwords used for video playback should not be personal.https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/41Get url path before unquote + change Thumbnail check2021-09-16T23:24:41+02:00Magnus GiesbertGet url path before unquote + change Thumbnail checkGet the url path before using `unquote`, circumventing problems with encoded special characters like '?'.
Get rid of the paths leading '/' so that the following if statements still work (this also gets rid of `.lstrip(config['VIDEOPREF...Get the url path before using `unquote`, circumventing problems with encoded special characters like '?'.
Get rid of the paths leading '/' so that the following if statements still work (this also gets rid of `.lstrip(config['VIDEOPREFIX'])`).
Change the auth check for thumbnails, from checking the ending('.jpg') to checking the beginning ('thumbnails/').https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/40Fixed authentication bypass2021-10-01T13:57:28+02:00Roman KarwacikFixed authentication bypassThis should fix the authentication bypass reported by Nils Beyer.This should fix the authentication bypass reported by Nils Beyer.https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/39Add download attribute to video_download_btn macro2021-08-09T10:55:09+02:00Magnus GiesbertAdd download attribute to video_download_btn macroStarts download dialog when pushing the download button instead of navigating to the video file.
Requested per mail "[Video] Download attribute" (01.08.2021)Starts download dialog when pushing the download button instead of navigating to the video file.
Requested per mail "[Video] Download attribute" (01.08.2021)https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/38Handle unwanted symbols in login username2020-10-19T23:46:39+02:00Magnus GiesbertHandle unwanted symbols in login usernameInstead of deleting non-conform symbols, return empty info and groups in `ldapauth`.
Solves Issue #385 .Instead of deleting non-conform symbols, return empty info and groups in `ldapauth`.
Solves Issue #385 .https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/37Draft:Userpages without direct userid2021-10-04T22:46:25+02:00Magnus GiesbertDraft:Userpages without direct useridMake sure the user in session sees only his personal pages and can not access the user pages of others.
Change paths to personal pages from internal/user/$userid$/$personalpage$ to internal/user/$personalpage$ and only use the sessions u...Make sure the user in session sees only his personal pages and can not access the user pages of others.
Change paths to personal pages from internal/user/$userid$/$personalpage$ to internal/user/$personalpage$ and only use the sessions uid internally to get the correct userid.
Also disable the userid given to navbaricon for userendpoints, because it became obsolete.https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/36Fix for authentification if both moodle and l2p rooms are available2020-07-23T18:14:59+02:00Roman KarwacikFix for authentification if both moodle and l2p rooms are availableBefore if both moodle and l2p rooms were available, only the l2p rooms would have been checked.Before if both moodle and l2p rooms were available, only the l2p rooms would have been checked.https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/35Improve/fix CI pipeline and linter2020-05-14T22:12:42+02:00Julian RotherImprove/fix CI pipeline and linterhttps://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/34Format strings not supported in 3.5.32020-05-08T16:48:09+02:00Roman KarwacikFormat strings not supported in 3.5.3https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/33Moodlesync debug2020-05-07T17:10:43+02:00Roman KarwacikMoodlesync debugIf moodleauth fails, send request to admins, no personal data shared as ``Data`` has to be None for it to trigger.If moodleauth fails, send request to admins, no personal data shared as ``Data`` has to be None for it to trigger.https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/32Fix Issue #3822020-05-07T11:46:46+02:00Magnus GiesbertFix Issue #382Zwei kleinere Fehler in fetch_ro_course_events gefixt.Zwei kleinere Fehler in fetch_ro_course_events gefixt.https://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/31Fix autoreload2020-05-01T13:03:54+02:00Roman KarwacikFix autoreloadhttps://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/30Fix autoreload after authentication2020-05-01T13:01:31+02:00Roman KarwacikFix autoreload after authenticationhttps://git.fsmpi.rwth-aachen.de/videoaginfra/website/-/merge_requests/29Moodle Authentication2020-04-27T17:41:45+02:00Roman KarwacikMoodle Authentication