From fd481eb04a7b12093e994b5da9424d87f58e5307 Mon Sep 17 00:00:00 2001
From: Dorian Koch <doriank@fsmpi.rwth-aachen.de>
Date: Fri, 27 Sep 2024 00:11:14 +0200
Subject: [PATCH] Do not delete jobs manually
---
config/job_controller_config.py | 5 -----
src/jobs/wrapped_job.py | 4 ----
2 files changed, 9 deletions(-)
diff --git a/config/job_controller_config.py b/config/job_controller_config.py
index 707b6dc..c33c2d8 100644
--- a/config/job_controller_config.py
+++ b/config/job_controller_config.py
@@ -11,8 +11,3 @@ POSTGRES = {
"database": "videoag"
}
'''
-
-# Whether to immediately delete jobs after they have been processed
-# Ideally everything that is needed will be extracted from the job and stored in the database, so this should be set to True
-DELETE_JOBS_AFTER_SUCCESS = True
-DELETE_JOBS_AFTER_FAILURE = False
diff --git a/src/jobs/wrapped_job.py b/src/jobs/wrapped_job.py
index 8f28541..d24b544 100644
--- a/src/jobs/wrapped_job.py
+++ b/src/jobs/wrapped_job.py
@@ -49,13 +49,9 @@ class WrappedJob(Event):
if self.job_state == JobState.FINISHED:
self.success(cstate)
self.jobData.update_state(cstate, JobState.FINISHED_AND_PROCESSED)
- if cstate.config.get("DELETE_JOBS_AFTER_SUCCESS", True):
- cstate.k8s.delete_job_by_id(self.job_id)
elif self.job_state == JobState.FAILED:
self.failure(cstate)
self.jobData.update_state(cstate, JobState.FAILED_AND_PROCESSED)
- if cstate.config.get("DELETE_JOBS_AFTER_FAILURE", True):
- cstate.k8s.delete_job_by_id(self.job_id)
else:
raise Exception(f"Job is in unexpected state: {self.job_state}")
--
GitLab