From 3aeb9dd8be1e08f02c5e1edc4ddf020de0629130 Mon Sep 17 00:00:00 2001
From: Dominic <git@msrd0.de>
Date: Tue, 9 Jan 2024 22:01:35 +0100
Subject: [PATCH] skip some irrelevant ffmpeg options

---
 src/render/ffmpeg.rs | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/render/ffmpeg.rs b/src/render/ffmpeg.rs
index 00597ca..c5557d7 100644
--- a/src/render/ffmpeg.rs
+++ b/src/render/ffmpeg.rs
@@ -92,7 +92,10 @@ impl FfmpegOutput {
 	}
 
 	pub(crate) fn enable_faststart(mut self) -> Self {
-		self.faststart = true;
+		// only enable faststart for MP4 containers
+		if matches!(self.format, FfmpegOutputFormat::AvcAac) {
+			self.faststart = true;
+		}
 		self
 	}
 
@@ -127,7 +130,7 @@ impl FfmpegOutput {
 		});
 		if let Some(ba) = self.audio_bitrate {
 			cmd.arg("-b:a").arg(ba.to_string());
-		} else {
+		} else if !matches!(self.format, FfmpegOutputFormat::Av1Flac) {
 			cmd.arg("-b:a").arg("128k");
 		}
 
-- 
GitLab