From 2b9e7f2d59f1eb07941ced36eac87a80a8c59cbc Mon Sep 17 00:00:00 2001
From: Hinrikus Wolf <hinrikus@fsmpi.rwth-aachen.de>
Date: Tue, 6 Mar 2018 13:42:20 +0100
Subject: [PATCH] ad-server: refactor role according todos

---
 ad-server/tasks/main.yml | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/ad-server/tasks/main.yml b/ad-server/tasks/main.yml
index fabc75d..88ea990 100644
--- a/ad-server/tasks/main.yml
+++ b/ad-server/tasks/main.yml
@@ -38,9 +38,7 @@
     - domain-provision
     - password
 
-
 # provision smb-domain. passwords will be selected at random and safed to /root/smb-provision.log)
-# TODO: Evaluate if internal DNS-backend is powerful enough for usecase otherwise bind9 is needed
 
 - name: ensure domain is provisioned
   shell: samba-tool domain provision --use-rfc2307 --domain={{ smb_domain }} --server-role=dc --host-name={{ ansible_hostname }} --realm={{ REALM }} --dns-backend=NONE --adminpass={{ adminpass.password }}  2> /root/smb-provision.log
@@ -69,10 +67,11 @@
     - ad-server
     - service
 
-#- name: ensure samba-ad-dc unit is running, enabled and not masked
-# systemd: name=samba-ad-dc masked=no state=running enabled=yes
-- debug:
-    msg: "Ensure samba-ad-dc unit is not masked.  This functionality will come in ansible 2.2, you should refactor this role"  
+- name: ensure samba-ad-dc unit is running, enabled and not masked
+  systemd: name=samba-ad-dc masked=no state=running enabled=yes
+  tags: 
+    - ad-server
+    - service
 
 - name: ensure samba-ad-dc is running and enabled
   service: name=samba-ad-dc state=running enabled=yes
@@ -80,5 +79,4 @@
     - ad-server
     - service
 
-
 - meta: flush_handlers
-- 
GitLab