From 25f2930c457acf4bf0041a87d616036634104f42 Mon Sep 17 00:00:00 2001
From: Lars Beckers <lars.beckers@rwth-aachen.de>
Date: Thu, 8 Aug 2019 00:30:46 +0200
Subject: [PATCH] fix linter errors

---
 localization/tasks/locale.yml |  2 +-
 shell/tasks/shell.yml         | 18 ++++++++++--------
 ssh-server/handlers/main.yml  |  9 ++++++---
 3 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/localization/tasks/locale.yml b/localization/tasks/locale.yml
index 288ef22..a6ae95b 100644
--- a/localization/tasks/locale.yml
+++ b/localization/tasks/locale.yml
@@ -9,7 +9,7 @@
 
 - name: ensure the default languages are enabled
   locale_gen:
-    name: "{{item}}.UTF-8"
+    name: "{{ item }}.UTF-8"
     state: present
   with_items: "{{ localization_enabled_locales }}"
   tags:
diff --git a/shell/tasks/shell.yml b/shell/tasks/shell.yml
index 603d49b..b1ac15f 100644
--- a/shell/tasks/shell.yml
+++ b/shell/tasks/shell.yml
@@ -50,7 +50,7 @@
 
 - name: ensure installation of variable additional software
   apt:
-    name: "{{shell_software}}"
+    name: "{{ shell_software }}"
     state: present
   tags:
     - packages
@@ -139,15 +139,16 @@
 
 - name: ensure directories for terminfo config files exist
   file:
-    path: "/etc/terminfo/{{item.path}}"
+    path: "/etc/terminfo/{{ item.path }}"
     owner: root
     group: root
     state: directory
     mode: '0755'
-  with_filetree: terminfo/
+  with_filetree:
+    - "terminfo/"
   when: item.state == "directory"
   loop_control:
-    label: "{{item.path}}"
+    label: "{{ item.path }}"
   tags:
     - config
     - shell
@@ -155,15 +156,16 @@
 
 - name: ensure strange terminals work well over ssh
   copy:
-    src: "{{item.src}}"
-    dest: "/etc/terminfo/{{item.path}}"
+    src: "{{ item.src }}"
+    dest: "/etc/terminfo/{{ item.path }}"
     owner: root
     group: root
     mode: '0644'
-  with_filetree: terminfo/
+  with_filetree:
+    - "terminfo/"
   when: item.state == "file"
   loop_control:
-    label: "{{item.path}}"
+    label: "{{ item.path }}"
   tags:
     - config
     - shell
diff --git a/ssh-server/handlers/main.yml b/ssh-server/handlers/main.yml
index 53644c0..9fc709c 100644
--- a/ssh-server/handlers/main.yml
+++ b/ssh-server/handlers/main.yml
@@ -1,8 +1,11 @@
 ---
-# file: roles/common/handlers/main.yml
 
 - name: restart sshd
-  service: name=ssh state=restarted
+  service:
+    name: ssh
+    state: restarted
 
 - name: regenerate pam config
-  shell: DEBIAN_FRONTEND=noninteractive pam-auth-update --force
+  command: pam-auth-update --force
+  environment:
+    DEBIAN_FRONTEND: noninteractive
-- 
GitLab